Index | Thread | Search

From:
Jonathan Matthew <jonathan@d14n.org>
Subject:
rkdwhdmi: pass correct node to pinctrl_byname()
To:
tech@openbsd.org
Cc:
kettenis@openbsd.org
Date:
Mon, 24 Mar 2025 08:44:21 +1000

Download raw body.

Thread
While looking through rkdwhdmi(4), I noticed the attach function
uses sc->sc_node before it's assigned.  faa->fa_node is valid
at this point, so it should use that instead.

ok?


Index: rkdwhdmi.c
===================================================================
RCS file: /cvs/src/sys/dev/fdt/rkdwhdmi.c,v
diff -u -p -r1.8 rkdwhdmi.c
--- rkdwhdmi.c	21 Aug 2024 11:24:12 -0000	1.8
+++ rkdwhdmi.c	23 Mar 2025 11:59:46 -0000
@@ -130,7 +136,7 @@ rkdwhdmi_attach(struct device *parent, s
 		return;
 	}
 
-	pinctrl_byname(sc->sc_node, "default");
+	pinctrl_byname(faa->fa_node, "default");
 
 	clock_enable(faa->fa_node, "iahb");
 	clock_enable(faa->fa_node, "isfr");