On Mon, Mar 24, 2025 at 11:41:00AM +0100, Mark Kettenis wrote:
> > Date: Mon, 24 Mar 2025 08:44:21 +1000
> > From: Jonathan Matthew <jonathan@d14n.org>
> > 
> > While looking through rkdwhdmi(4), I noticed the attach function
> > uses sc->sc_node before it's assigned.  faa->fa_node is valid
> > at this point, so it should use that instead.
> > 
> > ok?
> 
> Did you test this on an RK3399 board?  If so, ok kettenis@

It still works on my rockpro64.

> 
> > Index: rkdwhdmi.c
> > ===================================================================
> > RCS file: /cvs/src/sys/dev/fdt/rkdwhdmi.c,v
> > diff -u -p -r1.8 rkdwhdmi.c
> > --- rkdwhdmi.c	21 Aug 2024 11:24:12 -0000	1.8
> > +++ rkdwhdmi.c	23 Mar 2025 11:59:46 -0000
> > @@ -130,7 +136,7 @@ rkdwhdmi_attach(struct device *parent, s
> >  		return;
> >  	}
> >  
> > -	pinctrl_byname(sc->sc_node, "default");
> > +	pinctrl_byname(faa->fa_node, "default");
> >  
> >  	clock_enable(faa->fa_node, "iahb");
> >  	clock_enable(faa->fa_node, "isfr");
> > 
> >