Index | Thread | Search

From:
Philipp Klaus Krause <pkk@spth.de>
Subject:
Re: drop a useless function
To:
tech@openbsd.org
Date:
Tue, 8 Apr 2025 10:38:11 +0200

Download raw body.

Thread
Am 07.04.25 um 21:20 schrieb Jan Stary:
> @@ -358,7 +357,7 @@ show(char *zone, time_t t, int v)
>   	if (v) {
>   		tmp = gmtime(&t);
>   		if (tmp == NULL) {
> -			printf(tformat(), t);
> +			printf("%lld", t);

This assumes that time_t will always be the same as long long int. I
guess it is reasonable to assume that time_t will have at least 64 bits
for the foreseeable future. But is there a risk of long long becoming
wider than time_t for some platforms? If yes, I'd recommend to cast to a
suitable type, e.g.:

printf(PRIdLEAST64, (int_least64_t)t);

Philipp