Index | Thread | Search

From:
Florian Obser <florian@openbsd.org>
Subject:
Re: drop a useless function
To:
tech@openbsd.org
Date:
Tue, 08 Apr 2025 11:54:03 +0200

Download raw body.

Thread
  • Philipp Klaus Krause:

    drop a useless function

  • On 2025-04-08 10:38 +02, Philipp Klaus Krause <pkk@spth.de> wrote:
    > Am 07.04.25 um 21:20 schrieb Jan Stary:
    >> @@ -358,7 +357,7 @@ show(char *zone, time_t t, int v)
    >>   	if (v) {
    >>   		tmp = gmtime(&t);
    >>   		if (tmp == NULL) {
    >> -			printf(tformat(), t);
    >> +			printf("%lld", t);
    >
    > This assumes that time_t will always be the same as long long int. I
    > guess it is reasonable to assume that time_t will have at least 64 bits
    > for the foreseeable future. But is there a risk of long long becoming
    > wider than time_t for some platforms? If yes, I'd recommend to cast to a
    > suitable type, e.g.:
    >
    > printf(PRIdLEAST64, (int_least64_t)t);
    
    But what if the type changes during runtime, maybe to a float[1]?
    
    
    >
    > Philipp
    >
    
    [1] this is poking fun at openssl.
    https://youtu.be/GnBbhXBDmwU?t=2488
    
    -- 
    In my defence, I have been left unsupervised.
    
    
  • Philipp Klaus Krause:

    drop a useless function