Index | Thread | Search

From:
Nick Owens <mischief@offblast.org>
Subject:
Re: [PATCH] riscv64: make isa size bigger and terminate
To:
Miod Vallat <miod@online.fr>
Cc:
tech@openbsd.org
Date:
Sun, 15 Jun 2025 12:04:59 -0700

Download raw body.

Thread
On Sun, Jun 15, 2025 at 06:27:50PM +0000, Miod Vallat wrote:
> > i have swapped to using sizeof to terminate the buffer, instead of
> > trusting OF_getprop's return value.
> 
> What about invoking OF_getproplen() first, allocating the proper size
> with malloc(), and free()ing afterwards, so that this hardcoded 512
> doesn't need to become larger in a few years as more and extensions get
> designed and qemu pretends to support all of them?

ok. what do you suggest for the global cpu_model? should we store
something different/shorter there, like the 'compatible' property?