Index | Thread | Search

From:
Mark Kettenis <mark.kettenis@xs4all.nl>
Subject:
Re: [PATCH] riscv64: make isa size bigger and terminate
To:
Miod Vallat <miod@online.fr>
Cc:
mischief@offblast.org, tech@openbsd.org
Date:
Sun, 15 Jun 2025 21:16:20 +0200

Download raw body.

Thread
> Date: Sun, 15 Jun 2025 18:27:50 +0000
> From: Miod Vallat <miod@online.fr>
> Cc: tech@openbsd.org
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
> 
> > i have swapped to using sizeof to terminate the buffer, instead of
> > trusting OF_getprop's return value.
> 
> What about invoking OF_getproplen() first, allocating the proper size
> with malloc(), and free()ing afterwards, so that this hardcoded 512
> doesn't need to become larger in a few years as more and extensions get
> designed and qemu pretends to support all of them?

The whole riscv,isa "describe all the ISA extensions in a single
string" thing has been deprecated for a while now.  The code needs to
be rewritten to use riscv,isa-base and riscv,isa-extensions instead.