Index | Thread | Search

From:
Claudio Jeker <cjeker@diehard.n-r-g.com>
Subject:
Re: kern_timeout: Drop self-assignment in db_show_timeout
To:
Thorsten Blum <thorsten.blum@toblux.com>
Cc:
tech@openbsd.org
Date:
Mon, 13 Oct 2025 08:33:04 +0200

Download raw body.

Thread
On Sun, Oct 12, 2025 at 08:00:00PM +0200, Thorsten Blum wrote:
> Index: kern/kern_timeout.c
> ===================================================================
> RCS file: /cvs/src/sys/kern/kern_timeout.c,v
> retrieving revision 1.112
> diff -u -p -r1.112 kern_timeout.c
> --- kern/kern_timeout.c	28 Jul 2025 05:25:44 -0000	1.112
> +++ kern/kern_timeout.c	12 Oct 2025 16:01:05 -0000
> @@ -980,7 +980,8 @@ db_show_timeout(struct timeout *to, stru
>  	int width = sizeof(long) * 2;
>  
>  	db_find_sym_and_offset((vaddr_t)to->to_func, &name, &offset);
> -	name = name ? name : "?";
> +	if (!name)
> +		name = "?";
>  	if (bucket == &timeout_new)
>  		where = "new";
>  	else if (bucket == &timeout_todo)
> 

Why is this change needed? A decent compiler turns both into the same
code.

-- 
:wq Claudio