Index | Thread | Search

From:
Claudio Jeker <cjeker@diehard.n-r-g.com>
Subject:
Re: kern_timeout: Drop self-assignment in db_show_timeout
To:
Thorsten Blum <thorsten.blum@toblux.com>
Cc:
tech@openbsd.org
Date:
Mon, 13 Oct 2025 11:02:52 +0200

Download raw body.

Thread
On Mon, Oct 13, 2025 at 10:33:02AM +0200, Thorsten Blum wrote:
> On 13. Oct 2025, at 08:33, Claudio Jeker wrote:
> > On Sun, Oct 12, 2025 at 08:00:00PM +0200, Thorsten Blum wrote:
> >> Index: kern/kern_timeout.c
> >> ===================================================================
> >> RCS file: /cvs/src/sys/kern/kern_timeout.c,v
> >> [...]
> > 
> > Why is this change needed? A decent compiler turns both into the same
> > code.
> 
> I'd still like to believe we write code mostly for humans to read.

Using the ternary operator like this is a very common idiom. So why is
that less readable? This is a very simple line of code compared to other
bits even in that file.

-- 
:wq Claudio