Index | Thread | Search

From:
Marc Espie <marc.espie.openbsd@gmail.com>
Subject:
Re: patch: clean-up m4 function and macro names
To:
Omar Polo <op@omarpolo.com>
Cc:
tech@openbsd.org
Date:
Wed, 25 Feb 2026 00:09:27 +0100

Download raw body.

Thread
On Tue, Feb 24, 2026 at 10:02:54PM +0100, Omar Polo wrote:
> Marc Espie <marc.espie.openbsd@gmail.com> wrote:
> > Maybe it made sense to abbreviate things randomly 20 years ago,
> > but today, it only makes it more difficult to find things.
> > 
> > This patch renames a bunch of defines and function names to make
> > things simpler to follow.
> > 
> > Also reformat some comments with ludicrously short lines.
> > 
> > Some editorial choices: eval is the actual sanctionned macro name,
> > mkstemp reflects the actual semantics we chose.
> > 
> > And we keep unix as "selftype" since it could be used for other OS markers.
> > 
> > Also, rename indx to doindex to remove any ambiguity towards idx and
> > strstr, since the return values are notably different, and it matches
> > what actually happens.
> > 
> > There should be zero functional changes, just something that's clearer.
> 
> not familiar with the guts of m4 but agreed that this is an overall
> improvement.
> 
> fwiw (which is not much :P), okay op@
> 
Find somebody else (?) and commit it since I don't have my commit bit back
please ;)