Index | Thread | Search

From:
Sebastien Marie <semarie@kapouay.eu.org>
Subject:
Re: patch: clean-up m4 function and macro names
To:
Omar Polo <op@omarpolo.com>, Marc Espie <marc.espie.openbsd@gmail.com>
Cc:
tech@openbsd.org
Date:
Wed, 25 Feb 2026 07:39:38 +0100

Download raw body.

Thread
"Omar Polo" <op@omarpolo.com> writes:

> Marc Espie <marc.espie.openbsd@gmail.com> wrote:
>> Maybe it made sense to abbreviate things randomly 20 years ago,
>> but today, it only makes it more difficult to find things.
>> 
>> This patch renames a bunch of defines and function names to make
>> things simpler to follow.
>> 
>> Also reformat some comments with ludicrously short lines.
>> 
>> Some editorial choices: eval is the actual sanctionned macro name,
>> mkstemp reflects the actual semantics we chose.
>> 
>> And we keep unix as "selftype" since it could be used for other OS markers.
>> 
>> Also, rename indx to doindex to remove any ambiguity towards idx and
>> strstr, since the return values are notably different, and it matches
>> what actually happens.
>> 
>> There should be zero functional changes, just something that's clearer.
>
> not familiar with the guts of m4 but agreed that this is an overall
> improvement.
>
> fwiw (which is not much :P), okay op@

ok semarie@ too

op@, you commit it :)
-- 
Sebastien Marie