Index | Thread | Search

From:
Jonathan Gray <jsg@jsg.id.au>
Subject:
Re: dead code tells no tales, 7/16
To:
Miod Vallat <miod@online.fr>
Cc:
tech@openbsd.org
Date:
Mon, 21 Sep 2026 10:26:01 +1000

Download raw body.

Thread
On Sun, Sep 20, 2026 at 09:07:01PM +0000, Miod Vallat wrote:
> This routine does not seem to be used anymore.

though it is documented

diff --git share/man/man9/ml_init.9 share/man/man9/ml_init.9
index 30b8daba4d0..8951ceb6560 100644
--- share/man/man9/ml_init.9
+++ share/man/man9/ml_init.9
@@ -22,7 +22,6 @@
 .Nm ml_enqueue ,
 .Nm ml_dequeue ,
 .Nm ml_enlist ,
-.Nm ml_dechain ,
 .Nm ml_len ,
 .Nm ml_empty ,
 .Nm ml_hdatalen ,
@@ -42,8 +41,6 @@
 .Fn ml_dequeue "struct mbuf_list *ml"
 .Ft void
 .Fn ml_enlist "struct mbuf_list *ml" "struct mbuf_list *src"
-.Ft struct mbuf *
-.Fn ml_dechain "struct mbuf_list *ml"
 .Ft unsigned int
 .Fn ml_len "struct mbuf_list *ml"
 .Ft int
@@ -94,10 +91,6 @@ Enqueue all the mbufs on the
 mbuf list on to the end of the
 .Fa ml
 mbuf list.
-.It Fn ml_dechain "struct mbuf_list *ml"
-Dequeues all mbufs from the
-.Fa ml
-mbuf list.
 .It Fn ml_len "struct mbuf_list *ml"
 Return the number of mbufs on the
 .Fa ml
@@ -135,7 +128,6 @@ Note that it is unsafe to modify the list while iterating over it.
 .Fn ml_enqueue ,
 .Fn ml_dequeue ,
 .Fn ml_enlist ,
-.Fn ml_dechain ,
 .Fn ml_len ,
 .Fn ml_empty ,
 .Fn ml_purge ,
@@ -152,13 +144,6 @@ If the list was empty,
 .Dv NULL
 is returned.
 .Pp
-.Fn ml_dechain
-returns all the mbufs that were on the list via
-a pointer to an mbuf with the chain accessible via m_nextpkt members.
-If the list was empty,
-.Dv NULL
-is returned.
-.Pp
 .Fn ml_len
 returns the number of mbufs on the list.
 .Pp