Index | Thread | Search

From:
Jonathan Gray <jsg@jsg.id.au>
Subject:
Re: dead code tells no tales, 7/16
To:
Alexander Bluhm <bluhm@openbsd.org>
Cc:
Miod Vallat <miod@online.fr>, tech@openbsd.org
Date:
Mon, 21 Sep 2026 11:30:58 +1000

Download raw body.

Thread
On Mon, Sep 21, 2026 at 03:13:48AM +0200, Alexander Bluhm wrote:
> On Mon, Sep 21, 2026 at 10:26:01AM +1000, Jonathan Gray wrote:
> > On Sun, Sep 20, 2026 at 09:07:01PM +0000, Miod Vallat wrote:
> > > This routine does not seem to be used anymore.
> > 
> > though it is documented
> 
> because ml_dechain wants to offer the same API as mq_dechain
> mq_dechain is gone, it should be removed from mq_init man page

right, mq_dechain() was removed in uipc_mbuf.c

revision 1.300
date: 2025/06/25 20:26:32;  author: miod;  state: Exp;  lines: +1 -13;  commitid: A5SYlmg2gEBrq7R8;

Index: mq_init.9
===================================================================
RCS file: /cvs/src/share/man/man9/mq_init.9,v
diff -u -p -r1.13 mq_init.9
--- mq_init.9	28 Aug 2020 09:15:16 -0000	1.13
+++ mq_init.9	21 Sep 2026 01:23:39 -0000
@@ -24,7 +24,6 @@
 .Nm mq_dequeue ,
 .Nm mq_enlist ,
 .Nm mq_delist ,
-.Nm mq_dechain ,
 .Nm mq_len ,
 .Nm mq_empty ,
 .Nm mq_full ,
@@ -48,8 +47,6 @@
 .Fn mq_enlist "struct mbuf_queue *mq" "struct mbuf_list *ml"
 .Ft void
 .Fn mq_delist "struct mbuf_queue *mq" "struct mbuf_list *ml"
-.Ft struct mbuf *
-.Fn mq_dechain "struct mbuf_queue *mq"
 .Ft unsigned int
 .Fn mq_len "struct mbuf_queue *mq"
 .Ft int
@@ -143,10 +140,6 @@ Dequeue all the mbufs on the
 mbuf queue on to the
 .Fa ml
 mbuf list.
-.It Fn mq_dechain "struct mbuf_queue *mq"
-Dequeue all mbufs from the
-.Fa mq
-mbuf queue.
 .It Fn mq_len "struct mbuf_queue *mq"
 Return the number of mbufs on the
 .Fa mq
@@ -189,7 +182,6 @@ already exist on the queue.
 .Fn mq_dequeue ,
 .Fn mq_enlist ,
 .Fn mq_delist ,
-.Fn mq_dechain ,
 .Fn mq_len ,
 .Fn mq_empty ,
 .Fn mq_full ,
@@ -202,13 +194,6 @@ can be called during autoconf, from proc
 .Sh RETURN VALUES
 .Fn mq_dequeue
 returns the mbuf that was at the head of its queue.
-If the queue was empty,
-.Dv NULL
-is returned.
-.Pp
-.Fn mq_dechain
-returns all the mbufs that were on its queues via a pointer to an mbuf
-with the chain accessible via m_nextpkt members.
 If the queue was empty,
 .Dv NULL
 is returned.