Index | Thread | Search

From:
Janne Johansson <icepic.dz@gmail.com>
Subject:
Re: radeondrm: use the common KMS console path on sparc64
To:
Ted Bullock <tbullock@comlore.com>
Cc:
tech@openbsd.org
Date:
Tue, 6 Oct 2026 16:43:09 +0200

Download raw body.

Thread
Den tis 6 okt. 2026 kl 15:47 skrev Ted Bullock <tbullock@comlore.com>:

> On Tue, Oct 6, 2026 at 1:29 AM Janne Johansson <icepic.dz@gmail.com>
> wrote:
> >>
> >>         radeondrm_setpal(rdev, ri);
> >>         ri->ri_flg = RI_CENTER | RI_VCONS | RI_WRONLY;
> >> +#ifdef __sparc64__
> >> +       ri->ri_flg |= RI_BSWAP;
> >> +#endif
> >>         rasops_init(ri, 160, 160);
> >>
> >>         ri->ri_hw = rdev;
> >> -#endif
> >
> >
> > This feels like it should be guarded by an ifdef based on if the
> platform is big endian or not, and not just sparc64.
>
> Hi Janne,
>
> I checked this. Radeon already configures the framebuffer byte order
> handling for big endian. The additional difference on sparc64 is that
> it uses little endian pages for PCI framebuffer access. Mac and PowerPC
> don't do that. SPARC has its own approach to handling PCI.
> So I think this needs to stay sparc64, since the other platforms aren't
> affected by this change, to my knowledge.
>

I'll take your word for it, it's probably still better than not having that
patch, and
the amount of other bigendian XVR100 users might be zero, so..

-- 
May the most significant bit of your life be positive.