Crystal Kolipe <kolipe.c@exoticsilicon.com> wrote:

> On Thu, Mar 07, 2024 at 10:28:37AM -0700, Theo de Raadt wrote:
> > Crystal Kolipe <kolipe.c@exoticsilicon.com> wrote:
> > 
> > > On Thu, Mar 07, 2024 at 01:17:22PM +0100, Alexandre Ratchov wrote:
> > > > On Thu, Mar 07, 2024 at 08:26:46AM -0300, Crystal Kolipe wrote:
> > > > > With this first version of the code, these strings are unique.  Do we
> > > > > intend to guarantee this when the names are expanded to include further
> > > > > chipset information?
> > > > > 
> > > > 
> > > > You're right, the display strings can't be unique,
> > > > unfortunately. Furthermore, currently they are not stable with time.
> > > > 
> > > > > If not, should we mention this somewhere to avoid userland code relying
> > > > > on behaviour that will change later on?
> > > > > 
> > > > 
> > > > Sure. Something like this?
> > > 
> > > Looks good, but I think we should s/no/nor
> > > 
> > > Cc'ed Jason for a second opinion on this.
> > > 
> > > > 
> > > > --- a/libsndio/sioctl_open.3
> > > > +++ b/libsndio/sioctl_open.3
> > > > @@ -244,6 +244,7 @@ The
> > > >  .Fa display
> > > >  attribute contains an optional free-format string providing additional
> > > >  hints about the control, like the hardware model, or the units.
> > > > +It is neither unique at a given time, no stable with time.
> > > 
> > >  +It is neither unique at a given time, nor stable with time.
> > > 
> > > ( Maybe s/with/over/ as well? )
> > > 
> > 
> > 
> > I have no idea what that sentence means.
> 
> Maybe:
> 
> It is neither unique at a given time, nor stable _over_ time.
> 
> would be better English than:
> 
> It is neither unique at a given time, nor stable _with_ time.

Why does this need to be said?  Where is the implication that it doesn't
change??

I think this is ridiculous, why did anyone expect it to stay the same??

here's my retort:

Index: ls.1
===================================================================
RCS file: /cvs/src/bin/ls/ls.1,v
diff -u -p -u -r1.79 ls.1
--- ls.1        24 Oct 2016 13:46:58 -0000      1.79
+++ ls.1        7 Mar 2024 17:41:38 -0000
@@ -56,6 +56,10 @@ displays the names of files contained
 within that directory, as well as any requested, associated
 information.
 .Pp
+The output of.
+.Nm ls
+is neither unique at a given time, nor stable with time.
+.Pp
 If no operands are given, the contents of the current
 directory are displayed.
 If more than one operand is given,

Shall we add this to anything which can change to be different than
the second the system booted?